This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
[Linux] Auto-detect clang version #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BredPet
changed the title
BredPet
force-pushed
the
clang_version
branch
from
f0e80e4
to
dcf167e
Compare
BredPet
changed the title
jkotas
reviewed
Feb 5, 2018
| @@ -16,6 +16,7 @@ See the LICENSE file in the project root for more information. | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup> | |||
| <CppCompilerAndLinker Condition="'$(CppCompilerAndLinker)' == '' and '$(TargetOS)' == 'OSX'">clang</CppCompilerAndLinker> | |||
| <CppCompilerAndLinker Condition="'$(CppCompilerAndLinker)' == '' and '$(TargetOS)' == 'Linux' and '$(__ClangMajorVersion)' != '' and $(__ClangMinorVersion) != ''">clang-$(__ClangMajorVersion).$(__ClangMinorVersion)</CppCompilerAndLinker> | |||
There was a problem hiding this comment.
Could you please set CppCompilerAndLinker in buildvars-setup.sh instead?
The msbuild files under src/BuildIntegration are included in the ILCompiler NuGet package. They are used in dotnet cli integration. buildvars-setup.sh is for building CoreRT itself.
BredPet
force-pushed
the
clang_version
branch
from
dcf167e
to
a68475c
Compare
|
@jkotas please review again |
- Auto-detect if there is clang symlink and version is not specified - Remove hardcode clang version from msbuild file Signed-off-by: Petr Bred <bredpetr@gmail.com>
BredPet
force-pushed
the
clang_version
branch
from
a68475c
to
0276cd6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dotnet/arm32-corert-contrib please review